Skip to content

fix: exclude read-only is_default from customDomains #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kushalshit27 merged 2 commits into from
Jan 28, 2026
Merged

fix: exclude read-only is_default from customDomains #1279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01be8a8
fix: include 'is_default' property in custom domains handling
kushalshit27 Jan 27, 2026
94b6e87
Merge branch 'master' into DXCDT-1406-fix-custom-domains-is-default-p…
kushalshit27 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/tools/auth0/handlers/customDomains.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ export default class CustomDomainsHadnler extends DefaultAPIHandler {
'certificate',
'created_at',
'updated_at',
'is_default',
],
stripUpdateFields: [
'status',
Expand All @@ -74,6 +75,7 @@ export default class CustomDomainsHadnler extends DefaultAPIHandler {
'certificate',
'created_at',
'updated_at',
'is_default',
],
});
}
Expand Down
2 changes: 2 additions & 0 deletions test/tools/auth0/handlers/customDomains.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,7 @@ describe('#customDomains handler', () => {
primary: true, // should be stripped
verification: { method: 'cname' }, // should be stripped
verification_method: 'cname', // should be stripped
is_default: true, // should be stripped
tls_policy: 'recommended', // should NOT be stripped
domain_metadata: { key: 'value' }, // should NOT be stripped
};
Expand Down Expand Up @@ -405,6 +406,7 @@ describe('#customDomains handler', () => {
expect(updateCallData).to.not.have.property('primary');
expect(updateCallData).to.not.have.property('verification');
expect(updateCallData).to.not.have.property('verification_method');
expect(updateCallData).to.not.have.property('is_default');

// Verify that allowed fields are present
expect(updateCallData).to.have.property('tls_policy', 'recommended');
Expand Down