Add --smooth option, which will collect X samples (one per --interval…#49
Open
jvinet wants to merge 1 commit intoastrofrog:mainfrom
Open
Add --smooth option, which will collect X samples (one per --interval…#49jvinet wants to merge 1 commit intoastrofrog:mainfrom
jvinet wants to merge 1 commit intoastrofrog:mainfrom
Conversation
…) before logging/plotting; this will reduce the spikey-ness of the graph
|
The approach taken in this PR rolls the time window in window width increments (instead of in increments corresponding to the original time difference between samples), which adds a non-natural frequency component to the output, and after all doesn't smooth as "effectively" as it could. I think smoothing should be done using a "proper" rolling time window analysis. That's what I have made good experiences with over the years. I've implemented this approach in https://github.com/jgehrcke/goeffel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a new --smooth option, which will collect X samples (one per --interval) before logging/plotting; this will reduce the spikey-ness of the graph.
Here's an example of the difference using --interval 0.1 and --smooth 50 (= one graph/log point every 5 seconds).
And here's the same process without --smooth