Update dependencies (new semver) and fix some compile warnings#37
Open
VorpalBlade wants to merge 2 commits intoarchlinux:masterfrom
Open
Update dependencies (new semver) and fix some compile warnings#37VorpalBlade wants to merge 2 commits intoarchlinux:masterfrom
VorpalBlade wants to merge 2 commits intoarchlinux:masterfrom
Conversation
f86998e to
188615f
Compare
Author
|
After figuring out how to use cargo-semver-checks I fixed a number of semver issues. However it seems that there is one unavoidable issue: This is because the API of bitflags changed. We could define custom a impl that forwards to bitflags I suppose. It is your call what you want to do however. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps avoid duplicate dependencies in my program (two versions of bitflags).
I also fixed cargo build warnings. I did not look into the existing cargo clippy warnings.
I'm not sure if this is semver compatible or requires a new major release. I tried to use cargo-semver-checks to check this automatically but it doesn't work on alpm (see obi1kenobi/cargo-semver-checks#654). If it isn't semver compatible it is likely that some extra derives may be needed for the bitflags.