fix: Avoid modifying WDA sources #1101
Merged
+7
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@KazuCocoa Could you please try it on a real device when you have time? |
Member
|
(I'll test out this tonight) |
KazuCocoa
approved these changes
Jan 21, 2026
Member
KazuCocoa
left a comment
KazuCocoa
left a comment
There was a problem hiding this comment.
Nice to find the PRODUCT_BUNDLE_IDENTIFIER. On my env, it worked better with a free account than current method also
Member
|
I only applied below: |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 21, 2026
## [11.1.1](v11.1.0...v11.1.1) (2026-01-21) ### Bug Fixes * Avoid modifying WDA sources ([#1101](#1101)) ([5f2a00f](5f2a00f))
|
🎉 This PR is included in version 11.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not try to modify WDA sources as node modules might be read only. Also, this does not work well for parallel runs.
Related to https://github.com/orgs/appium/discussions/16