Accept mode param in image size definition#5
Open
lucaslopez wants to merge 2 commits intoapostrophecms:mainfrom
Open
Accept mode param in image size definition#5lucaslopez wants to merge 2 commits intoapostrophecms:mainfrom
lucaslopez wants to merge 2 commits intoapostrophecms:mainfrom
Conversation
This modification adds the possibility to add a new parameter in the images size definition: mode. If mode = 'cropCenter', the image will be cropped to match the specified dimensions, no matter the original aspect ratio. If not specified the default behavior will be applied. This is handy if you need to have different aspect ratios in the same image, by cropping them centered. If the image is smaller than the required dimensions, it will be amplified.
Contributor
|
Please include documentation of the new option and passing tests if you are still interested in this feature. I realize we're criminally late responding. Sorry for the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modification adds the possibility to add a new parameter in the images size definition: mode.
If mode = 'cropCenter', the image will be cropped to match the specified dimensions, no matter the original aspect ratio.
If not specified the default behavior will be applied.
This is handy if you need to have different aspect ratios in the same image, by cropping them centered. If the image is smaller than the required dimensions, it will be amplified.
For instance:
addImageSizes:
[
{
name: 'listado-1',
mode: 'cropCenter',
width: 440,
height: 250
}
]