fix: escape unclosed tags without closing bracket in escape mode (#706)#720
Open
choi2601 wants to merge 2 commits intoapostrophecms:mainfrom
Open
fix: escape unclosed tags without closing bracket in escape mode (#706)#720choi2601 wants to merge 2 commits intoapostrophecms:mainfrom
choi2601 wants to merge 2 commits intoapostrophecms:mainfrom
Conversation
Contributor
|
Thanks for this contribution. We will try to take a look and get back to you soon. However, could you update the |
Author
|
@BoDonkey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the issue where unclosed tags (e.g.,
<hello,<hello attr) resulted in an empty string whendisallowedTagsModeis set to'escape'or'recursiveEscape'.htmlparser2drops malformed/unclosed tags at the end of the input stream without firing events. Added logic to checkparser.endIndexafter parsing completes to capture and escape any remaining unparsed content.Closes #706
What are the specific steps to test this change?
npm test<helloescape<hello<hellorecursiveEscape<hello<hello youescape<hello you<hello yourecursiveEscape<hello you<hellodiscard''(empty)Hello <worldescapeHello <worldHello <worldrecursiveEscapeHello <worldResult: All 190 tests passing (183 existing + 7 new)
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
Other information:
escape,recursiveEscape, anddiscardmodesparser.endIndex(public API) from htmlparser2 to detect unparsed trailing content