Fix tutorial 18584 #18696

AshwiniBokka · 2026-01-29T14:04:42Z

No description provided.

…error

- Add prerequisite note about building TVM with CUDA support - Add error handling for 'tvm_ffi' import failure with helpful message - Direct users to build instructions when TVM is not built - Fixes issue apache#18584 where users get confusing import errors Test Plan: - File compiles without syntax errors - Error message guides users to correct solution

gemini-code-assist · 2026-01-29T14:04:56Z

Summary of Changes

Hello @AshwiniBokka, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the user experience and reliability of a specific tutorial by addressing a common dependency issue. It ensures that users encountering problems related to CUDA support receive clear guidance. Additionally, it includes minor but important updates to license links, promoting secure access to Apache License documentation.

Highlights

Tutorial Robustness: The customize_opt.py tutorial has been made more robust by adding explicit checks and error messages for TVM's CUDA build dependency, guiding users on how to resolve ImportError related to tvm_ffi.
License URL Updates: All Apache License URLs across LICENSE and README.md files have been updated from http to https for improved security and best practices.
File Encoding: A UTF-8 Byte Order Mark (BOM) has been added to the customize_opt.py file.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request primarily updates HTTP links to HTTPS across the repository, which is a good security improvement. It also enhances the customize_opt.py tutorial by adding a check for CUDA support, improving the user experience. My review includes a few suggestions for this tutorial script to align with best practices, such as removing an unnecessary Byte Order Mark, directing error messages to stderr, and cleaning up trailing newlines.

gemini-code-assist · 2026-01-29T14:06:07Z

docs/how_to/tutorials/customize_opt.py

@@ -1,4 +1,4 @@
-# Licensed to the Apache Software Foundation (ASF) under one
+# Licensed to the Apache Software Foundation (ASF) under one


This line contains a Unicode Byte Order Mark (BOM) \ufeff, which is unnecessary for UTF-8 encoded files and can cause issues with some tools. It should be removed.

Suggested change

# Licensed to the Apache Software Foundation (ASF) under one

# Licensed to the Apache Software Foundation (ASF) under one

pls take a look

gemini-code-assist · 2026-01-29T14:06:07Z

docs/how_to/tutorials/customize_opt.py

+        print("Error: TVM needs to be built with CUDA support.")
+        print("Please build TVM from source with CUDA enabled.")
+        print("See: https://tvm.apache.org/docs/install/from_source.html")
+        import sys


Error messages should be printed to standard error (stderr) instead of standard output (stdout). This is a standard practice for separating diagnostic output from normal program output. Also, it's better to move the import sys statement to the top of the except block.

Suggested change

print("Error: TVM needs to be built with CUDA support.")

print("Please build TVM from source with CUDA enabled.")

print("See: https://tvm.apache.org/docs/install/from_source.html")

import sys

import sys

print("Error: TVM needs to be built with CUDA support.", file=sys.stderr)

print("Please build TVM from source with CUDA enabled.", file=sys.stderr)

print("See: https://tvm.apache.org/docs/install/from_source.html", file=sys.stderr)

gemini-code-assist · 2026-01-29T14:06:07Z

docs/how_to/tutorials/customize_opt.py

 # iterate the optimization and improve the performance of the model.
 #
+
+


There are multiple empty lines at the end of the file. It's a common convention to have only a single newline at the end of a file. Please remove the extra ones.

- Properly indent except ImportError block - Remove duplicate import sys statement - Ensure if/else block has correct indentation - All error messages use sys.stderr - File now compiles without syntax errors Addresses all code review feedback

yongwww · 2026-01-29T14:31:12Z

docs/how_to/tutorials/customize_opt.py

@@ -1,4 +1,4 @@
-# Licensed to the Apache Software Foundation (ASF) under one
+# Licensed to the Apache Software Foundation (ASF) under one


pls take a look

yongwww · 2026-01-29T14:34:58Z

docs/how_to/tutorials/customize_opt.py

 from tvm.relax.frontend import nn

+# Note: This tutorial requires TVM to be built with CUDA support.
+# If you encounter 'No module named ''tvm_ffi''' error,


tvm_ffi can be installed with cd 3rdparty/tvm-ffi; pip install .

yongwww · 2026-01-29T14:40:05Z

LICENSE

                                 Apache License
                           Version 2.0, January 2004
-                        http://www.apache.org/licenses/
+                        https://www.apache.org/licenses/


The LICENSE update isn’t related to this PR. I’d suggest we avoid changing it here and handle it in a separate PR if needed.

yongwww · 2026-01-29T14:41:31Z

docs/how_to/tutorials/customize_opt.py

-
+try:
+    import tvm.relax.backend.cuda.cublas as _cublas
+except ImportError as e:


probably we don't have to handle the tvm_ffi specifically here

AshwiniBokka added 5 commits January 25, 2026 17:16

docs: update http to https in license link

a65fb44

docs: update http to https in LICENSE file (lines 3 and 195)

8d74f25

docs: add contributor entry

fceb7da

fix: add missing trailing newline to CONTRIBUTORS.md to resolve lint …

2201b99

…error

gemini-code-assist bot reviewed Jan 29, 2026

View reviewed changes

AshwiniBokka closed this Jan 29, 2026

yongwww requested changes Jan 29, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix tutorial 18584 #18696

Fix tutorial 18584 #18696

AshwiniBokka commented Jan 29, 2026

Uh oh!

gemini-code-assist bot commented Jan 29, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 29, 2026

Uh oh!

yongwww Jan 29, 2026

Uh oh!

gemini-code-assist bot Jan 29, 2026

Uh oh!

gemini-code-assist bot Jan 29, 2026

Uh oh!

yongwww Jan 29, 2026

Uh oh!

yongwww Jan 29, 2026

Uh oh!

yongwww Jan 29, 2026

Uh oh!

yongwww Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -1,4 +1,4 @@
		# Licensed to the Apache Software Foundation (ASF) under one
		# Licensed to the Apache Software Foundation (ASF) under one

		# iterate the optimization and improve the performance of the model.
		#

Fix tutorial 18584 #18696

Fix tutorial 18584 #18696

Conversation

AshwiniBokka commented Jan 29, 2026

Uh oh!

gemini-code-assist bot commented Jan 29, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

yongwww Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

yongwww Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

yongwww Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

yongwww Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

yongwww Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants