SOLR-16738: Refactor special-casing out of AdminHandlersProxy #3991
+238
−103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16738
Description
AdminHandlersProxy, in its current form, is a bit unwieldy to extend to cover our v2 API: it relies on GenericSolrRequest to send requests, assumes a NamedList in several method signatures, assumes certain parameter names as triggers for proxying, and even has special cases for certain "wt" values. To truly support v2-proxying, AdminHandlersProxy would need to be more flexible about parameter names and SolrJ return types.
Solution
This PR refactors AdminHandlersProxy to make it more amendable for use with v2 APIs going forward. The refactor makes the following changes:
o.a.s.handler.admin.proxyTests
Unit tests for AdminHandlersProxy, PrometheusRequestProxy, and NormalV1RequestProxy will be added prior to coming out of "draft" mode.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.