HDDS-14250. Improve error logging in S3 gateway ObjectEndpoint #9562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivandika3
reviewed
Dec 27, 2025
Contributor
There was a problem hiding this comment.
Thanks @rich7420 for the patch. However, since we already have audit logs which logs the exception, adding exception might double the number of logs without any additional benefits. For example, for OMException like KEY_NOT_FOUND might flood the S3G logs.
Contributor
+1 Such error logging was removed in HDDS-6904, so let's not restore it. |
Contributor
Author
|
no problem! thanks for the review @adoroszlai and @ivandika3 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR added error logger for ObjectEndpoint.
What is the link to the Apache JIRA
HDDS-14250
How was this patch tested?
https://github.com/rich7420/ozone/actions/runs/20524595434