HDDS-14022. Move HddsUtils.getSCMAddressForDatanodes to HddsServerUtil #9556
+268
−261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rich7420
approved these changes
Dec 25, 2025
Contributor
|
@Russole thanks for the patch! LGTM! |
adoroszlai
reviewed
Dec 26, 2025
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @Russole for the patch, LGTM. However, I just noticed that getReconAddresses should also be moved (and please rename it to getReconAddressForDatanodes, since it is a single, datanode-specific address). Sorry for missing it in the Jira description.
Contributor
Author
|
Thanks @rich7420 and @adoroszlai for the reviews. I’ve now moved |
adoroszlai
approved these changes
Dec 27, 2025
Contributor
Contributor
|
@Russole , @adoroszlai thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
*Moved
getSCMAddressForDatanodes(both overloads) fromHddsUtilstoHddsServerUtil, as they are only used by server-side components.*Relocated test cases covering
getSCMAddressForDatanodesfromTestHddsUtilstoTestHddsServerUtil.*Updated imports and references to match the new utility location.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14022
How was this patch tested?
I relied on existing unit and integration tests, and verified that the full CI passed on my fork.
Please let me know if additional tests are needed.