Skip to content

Conversation

@rich7420
Copy link
Contributor

Purpose of PR

Adds comprehensive test suite for rotation gates (RX, RY, RZ) with 78 parameterized test cases covering angle variations, parameterized gates, parameter binding, and edge cases across all backends (Qiskit, Cirq, Amazon Braket).

Related Issues or PRs

A part of #604

Changes Made

  • Bug fix
  • New feature
  • Refactoring
  • Documentation
  • Test
  • CI/CD pipeline
  • Other

Breaking Changes

  • Yes
  • No

Checklist

  • Added or updated unit tests for all changes
  • Added or updated documentation for all changes
  • Successfully built and ran all unit tests or manual tests locally
  • PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
  • Code follows ASF guidelines

@rich7420
Copy link
Contributor Author

this failure is because the error of amazon backend. #613

@guan404ming
Copy link
Member

We can mark this as a draft for now. That’ll help prevent it from going into pre-review

@guan404ming guan404ming marked this pull request as draft November 13, 2025 02:16
@rich7420
Copy link
Contributor Author

No problem! thanks!

@guan404ming guan404ming marked this pull request as ready for review November 14, 2025 10:16
@guan404ming
Copy link
Member

I think the error would be fixed after rebased.

Copy link
Member

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rich7420
Copy link
Contributor Author

@guan404ming I've rebased to the latest branch.

@guan404ming guan404ming merged commit a9e1d82 into apache:main Nov 15, 2025
4 checks passed
@guan404ming
Copy link
Member

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants