This repository was archived by the owner on Sep 13, 2023. It is now read-only.
#Bug 58062 Close IO Streams in finally statement#2
Open
xinyeah wants to merge 1 commit intoapache:BRANCH_1_3_ABANDONEDfrom
Open
#Bug 58062 Close IO Streams in finally statement#2xinyeah wants to merge 1 commit intoapache:BRANCH_1_3_ABANDONEDfrom
xinyeah wants to merge 1 commit intoapache:BRANCH_1_3_ABANDONEDfrom
Conversation
Place the close method in the finally clause, so we can ensure it always runs regardless of how the method exits.
|
Hi, thanks for the contribution! While this looks like a good improvement, log4j 1.x is end-of-life so this kind of maintenance is not being done unless it fixes a critical security issue, which I think is not the case here. See https://logging.apache.org/log4j/1.2/ for more information. I think this PR can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Place the close method in the finally clause, so we can ensure it always
runs regardless of how the method exits.