This repository was archived by the owner on Sep 13, 2023. It is now read-only.
Conversation
downdrown
reviewed
Feb 6, 2020
| static | ||
| public | ||
| Logger getLogger(String name) { | ||
| Logger getLoggerID(String name) { |
There was a problem hiding this comment.
Whats wrong/irritating about #getLogger(String)?
IMHO #getLoggerID(String) is much more misleading, since the return type of this method is a Logger, not an ID ...
Author
|
Hello,
please close this one. In a workshop I help spontaniously we needed an example of a pull request and I used your repo.
Sorry for not taking back the pull request myself.
Kindest regards
Sönke Gissel
Von: Manfred Huber <notifications@github.com>
Gesendet: Donnerstag, 6. Februar 2020 10:02
An: apache/log4j <log4j@noreply.github.com>
Cc: Gissel, Sönke <s.gissel@serrala.com>; Author <author@noreply.github.com>
Betreff: Re: [apache/log4j] Sprechender Name (#11)
@downdrown commented on this pull request.
________________________________
In src/main/java/org/apache/log4j/Logger.java<#11 (comment)>:
@@ -54,15 +54,15 @@
*/
static
public
- Logger getLogger(String name) {
+ Logger getLoggerID(String name) {
Whats wrong/irritating about #getLogger(String)?
IMHO #getLoggerID(String) is much more misleading, since the return type of this method is a Logger, not an ID ...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#11>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANLBURXTJWU25SCIBDCE4VTRBPG2JANCNFSM4KEZE6YQ>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.