feat: add schema update to table metadata builder #437
+711
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gty404
force-pushed
the
update-schema
branch
from
7836c3e to
62960f3
Compare
HeartLinked
reviewed
Dec 25, 2025
WZhuo
reviewed
Dec 25, 2025
WZhuo
reviewed
Dec 25, 2025
WZhuo
approved these changes
Dec 25, 2025
gty404
force-pushed
the
update-schema
branch
from
012079a to
16e797e
Compare
wgtmac
reviewed
Dec 25, 2025
wgtmac
approved these changes
Dec 26, 2025
|
|
||
| Status PartitionSpec::ValidatePartitionName(const Schema& schema) const { | ||
| Status PartitionSpec::ValidatePartitionName(const Schema& schema, | ||
| const PartitionSpec& spec) { |
Member
There was a problem hiding this comment.
Do we need to add an extra parameter case_sensitive?
Member
There was a problem hiding this comment.
BTW, Java impl also has checkForRedundantPartitions, do we want to add that check? We can add a TODO somewhere if necessary.
Contributor
Author
There was a problem hiding this comment.
Okay, I will align the check of partition spec with java in a separate pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.