Skip to content

Conversation

@nadment
Copy link
Contributor

@nadment nadment commented Jan 4, 2026

  • Add a visual indicator if a hop candidate already exists
  • Add a visual indicator when a hop candidate create a loop in workflow or pipeline
  • Avoids side effects when drawing a new hop candidate and clicking on a action/transfo name, hop, or note.
  • Reduce the size of the red cross.
  • Some doc cleanup
  • The visual indicator does not take into account the offset in the pipeline graph

@hansva can you test if there is no duplicate pop-up for hop handling, I removed some Mac-specific code at line 738 of PipelineGraph.

@nadment nadment added this to the 2.17 milestone Jan 4, 2026
@nadment nadment added the Hop Gui label Jan 4, 2026
@nadment nadment linked an issue Jan 4, 2026 that may be closed by this pull request
@nadment nadment requested a review from hansva January 4, 2026 20:18
@hansva
Copy link
Contributor

hansva commented Jan 6, 2026

Looking good, I have not found any issues

@hansva hansva merged commit 2e399c6 into apache:main Jan 6, 2026
2 checks passed
@github-actions github-actions bot removed this from the 2.17 milestone Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Prevent the creation of invalid hops in a visual manner

2 participants