Support parsing parenthesized wildcard (*)
#2123
Merged
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Dec 4, 2025
tests/sqlparser_common.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| fn parse_select_distinct_parenthesized_wildcard() { |
Contributor
There was a problem hiding this comment.
Suggested change
| fn parse_select_distinct_parenthesized_wildcard() { | |
| fn parse_select_parenthesized_wildcard() { |
thinking since the syntax isn't implemented solely on the distinct keyword?
src/parser/mod.rs
Outdated
| self.next_token(); // consume RParen | ||
| return Ok(Expr::Wildcard(AttachedToken(inner_token))); | ||
| } | ||
| // Not a (*), reset and fall through to parse_expr |
Contributor
There was a problem hiding this comment.
this looks incorrect per the comment, by reset should we have called prev_token() or similar to undo the consumed inner token *?
src/parser/mod.rs
Outdated
Comment on lines
1227
to
1228
| let inner_token = self.next_token(); | ||
| if inner_token.token == Token::Mul && self.peek_token().token == Token::RParen { |
Contributor
There was a problem hiding this comment.
can this be simplified by calling self.peek_tokens_ref(Token::MUL, Token::RParen)?
Contributor
Author
|
@iffyio Updated. Thank you for reviewing |
iffyio
reviewed
Dec 10, 2025
src/parser/mod.rs
Outdated
Comment on lines
1233
to
1234
| // Not a (*), fall through to reset index and call parse_expr | ||
| self.prev_token(); |
Contributor
There was a problem hiding this comment.
calling self.prev_token() doesn't seem needed? similar to the _ branch, the fall-through paths call self.index = index; to reset at the end it looks like
romanoff
force-pushed
the
allow_parsing_parenthesized_wildcard
branch
from
fa70750 to
3732a4a
Compare
iffyio
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support parsing parenthesized wildcard
(*)Example of query: