build: reduce combinatorial explosion in temporal fuzz tests #3250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The temporal tests had 72 configurations (3 output types × 3 timezones × 2 × 2 × 2 settings), reduced to 10 configurations: - INT96: 2 timezones × 3 int96 combinations = 6 configs - TIMESTAMP_MICROS/MILLIS: 2 timezones × 1 combination = 2 configs each Key changes: - INT96-specific settings only tested for INT96 format (where they matter) - Reduced timezones from 3 to 2 (local + UTC) - Removed inferTimestampNtzEnabled loop (not relevant for this test) - Added TimestampType column to properly exercise timestamp settings This reduces temporal test time by ~5x. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3250 +/- ##
============================================
+ Coverage 56.12% 60.00% +3.87%
- Complexity 976 1428 +452
============================================
Files 119 170 +51
Lines 11743 15796 +4053
Branches 2251 2608 +357
============================================
+ Hits 6591 9478 +2887
- Misses 4012 5000 +988
- Partials 1140 1318 +178 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
int96AsTimestamp,int96TimestampConversion) now only tested for INT96 formatinferTimestampNtzEnabledloop (not relevant for this test's focus)TimestampTypecolumn to properly exercise timestamp settingsTest plan
CometFuzzTestSuitetemporal tests - all pass🤖 Generated with Claude Code