Skip to content

PoolingPolicy support UnpooledDirect #4643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaozhangmin wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

PoolingPolicy support UnpooledDirect #4643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...-common-allocator/src/main/java/org/apache/bookkeeper/common/allocator/PoolingPolicy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ public enum PoolingPolicy {
*/
UnpooledHeap,

UnpooledDirect,

/**
* Use Direct memory for all buffers and pool the memory.
*
Expand Down
2 changes: 1 addition & 1 deletion ...cator/src/main/java/org/apache/bookkeeper/common/allocator/impl/ByteBufAllocatorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ public ByteBuf buffer(int initialCapacity) {

@Override
public ByteBuf buffer(int initialCapacity, int maxCapacity) {
if (poolingPolicy == PoolingPolicy.PooledDirect) {
if (poolingPolicy == PoolingPolicy.PooledDirect || poolingPolicy == PoolingPolicy.UnpooledDirect) {
Copy link
Member

@StevenLuMT StevenLuMT Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PooledDirect and UnpooledDirect have the same implementation logic, so what's the point of adding this enumeration? I don't quite understand the purpose of your change.

Also, for the new types, I suggest adding testcase coverage.

Copy link
Contributor Author

@gaozhangmin gaozhangmin Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

poolingPolicy == PoolingPolicy.PooledDirect condition in newDirectBuffer

Copy link

@xiezhx9 xiezhx9 Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unpooled did the same thing here

poolingPolicy == PoolingPolicy.PooledDirect condition in newDirectBuffer

return newDirectBuffer(initialCapacity, maxCapacity, true /* can fallback to heap if needed */);
} else {
return newHeapBuffer(initialCapacity, maxCapacity);
Expand Down
Loading