Skip to content

GH-48658: [R] Add test for slice_sample with prop = 1 edge case #48659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonkeane merged 1 commit into from
Dec 27, 2025
+9 −1
Merged

GH-48658: [R] Add test for slice_sample with prop = 1 edge case #48659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion r/tests/testthat/test-dplyr-slice.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,4 +218,12 @@ test_that("n <-> prop conversion when nrow is not known", {
)
})

# TODO: handle edge case where prop = 1, do nothing?
test_that("slice_sample with prop = 1 returns all data", {
# When prop = 1, no filtering should occur and all data should be returned
tab <- arrow_table(tbl)
result <- tab |>
slice_sample(prop = 1) |>
collect()
expect_equal(nrow(result), nrow(tbl))
expect_setequal(result$int, tbl$int)
})
Loading