Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the stable Fluent image version from 26.1 to 27.1 across the codebase, ensuring that nightly development tests and force update workflows use the latest stable image.
Changes:
- Updated Fluent image tags and version references from v26.1/261 to v27.1/271 in GitHub workflows
- Added new Makefile targets for version 27.1 unit tests (dev, all, solvermode, and no-codegen variants)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Makefile | Added four new test targets for Fluent version 27.1 |
| .github/workflows/test-run-dev-version-nightly.yml | Updated environment variables to use Fluent 27.1 image |
| .github/workflows/force-update-stable-Fluent-image-version.yml | Updated environment variables to use Fluent 27.1 image |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | ||
| @python -m pytest --fluent-version=26.1 $(PYTESTEXTRA) || python -m pytest --fluent-version=26.1 $(PYTESTRERUN) | ||
|
|
||
| unittest-dev-271: |
There was a problem hiding this comment.
The target name uses '271' to represent version 27.1, which is inconsistent with how other version numbers are represented. Consider using 'unittest-dev-27-1' or a similar format that clearly indicates this is version 27.1, not version 271.
| unittest-dev-271: | |
| unittest-dev-27-1: |
| unittest-all-271: | ||
| @echo "Running all unittests" | ||
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | ||
| @python -m pytest --nightly --fluent-version=27.1 $(PYTESTEXTRA) || python -m pytest --nightly --fluent-version=27.1 $(PYTESTRERUN) | ||
|
|
||
| unittest-solvermode-271: | ||
| @echo "Running all unittests" | ||
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | ||
| @python -m pytest --fluent-version=27.1 --solvermode $(PYTESTEXTRA) || python -m pytest --fluent-version=27.1 --solvermode $(PYTESTRERUN) | ||
|
|
||
| unittest-all-271-no-codegen: |
There was a problem hiding this comment.
All three target names use '271' to represent version 27.1. This is inconsistent with the version representation and could be confused with version 271. The naming should clearly indicate version 27.1.
| unittest-all-271: | |
| @echo "Running all unittests" | |
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | |
| @python -m pytest --nightly --fluent-version=27.1 $(PYTESTEXTRA) || python -m pytest --nightly --fluent-version=27.1 $(PYTESTRERUN) | |
| unittest-solvermode-271: | |
| @echo "Running all unittests" | |
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | |
| @python -m pytest --fluent-version=27.1 --solvermode $(PYTESTEXTRA) || python -m pytest --fluent-version=27.1 --solvermode $(PYTESTRERUN) | |
| unittest-all-271-no-codegen: | |
| unittest-all-27_1: | |
| @echo "Running all unittests" | |
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | |
| @python -m pytest --nightly --fluent-version=27.1 $(PYTESTEXTRA) || python -m pytest --nightly --fluent-version=27.1 $(PYTESTRERUN) | |
| unittest-solvermode-27_1: | |
| @echo "Running all unittests" | |
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | |
| @python -m pytest --fluent-version=27.1 --solvermode $(PYTESTEXTRA) || python -m pytest --fluent-version=27.1 --solvermode $(PYTESTRERUN) | |
| unittest-all-27_1-no-codegen: |
| unittest-all-271: | ||
| @echo "Running all unittests" | ||
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | ||
| @python -m pytest --nightly --fluent-version=27.1 $(PYTESTEXTRA) || python -m pytest --nightly --fluent-version=27.1 $(PYTESTRERUN) | ||
|
|
||
| unittest-solvermode-271: | ||
| @echo "Running all unittests" | ||
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | ||
| @python -m pytest --fluent-version=27.1 --solvermode $(PYTESTEXTRA) || python -m pytest --fluent-version=27.1 --solvermode $(PYTESTRERUN) | ||
|
|
||
| unittest-all-271-no-codegen: |
There was a problem hiding this comment.
All three target names use '271' to represent version 27.1. This is inconsistent with the version representation and could be confused with version 271. The naming should clearly indicate version 27.1.
| unittest-all-271: | |
| @echo "Running all unittests" | |
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | |
| @python -m pytest --nightly --fluent-version=27.1 $(PYTESTEXTRA) || python -m pytest --nightly --fluent-version=27.1 $(PYTESTRERUN) | |
| unittest-solvermode-271: | |
| @echo "Running all unittests" | |
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | |
| @python -m pytest --fluent-version=27.1 --solvermode $(PYTESTEXTRA) || python -m pytest --fluent-version=27.1 --solvermode $(PYTESTRERUN) | |
| unittest-all-271-no-codegen: | |
| unittest-all-27_1: | |
| @echo "Running all unittests" | |
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | |
| @python -m pytest --nightly --fluent-version=27.1 $(PYTESTEXTRA) || python -m pytest --nightly --fluent-version=27.1 $(PYTESTRERUN) | |
| unittest-solvermode-27_1: | |
| @echo "Running all unittests" | |
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | |
| @python -m pytest --fluent-version=27.1 --solvermode $(PYTESTEXTRA) || python -m pytest --fluent-version=27.1 --solvermode $(PYTESTRERUN) | |
| unittest-all-27_1-no-codegen: |
| unittest-all-271: | ||
| @echo "Running all unittests" | ||
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | ||
| @python -m pytest --nightly --fluent-version=27.1 $(PYTESTEXTRA) || python -m pytest --nightly --fluent-version=27.1 $(PYTESTRERUN) | ||
|
|
||
| unittest-solvermode-271: | ||
| @echo "Running all unittests" | ||
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | ||
| @python -m pytest --fluent-version=27.1 --solvermode $(PYTESTEXTRA) || python -m pytest --fluent-version=27.1 --solvermode $(PYTESTRERUN) | ||
|
|
||
| unittest-all-271-no-codegen: |
There was a problem hiding this comment.
All three target names use '271' to represent version 27.1. This is inconsistent with the version representation and could be confused with version 271. The naming should clearly indicate version 27.1.
| unittest-all-271: | |
| @echo "Running all unittests" | |
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | |
| @python -m pytest --nightly --fluent-version=27.1 $(PYTESTEXTRA) || python -m pytest --nightly --fluent-version=27.1 $(PYTESTRERUN) | |
| unittest-solvermode-271: | |
| @echo "Running all unittests" | |
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | |
| @python -m pytest --fluent-version=27.1 --solvermode $(PYTESTEXTRA) || python -m pytest --fluent-version=27.1 --solvermode $(PYTESTRERUN) | |
| unittest-all-271-no-codegen: | |
| unittest-all-27_1: | |
| @echo "Running all unittests" | |
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | |
| @python -m pytest --nightly --fluent-version=27.1 $(PYTESTEXTRA) || python -m pytest --nightly --fluent-version=27.1 $(PYTESTRERUN) | |
| unittest-solvermode-27_1: | |
| @echo "Running all unittests" | |
| @sudo rm -rf /home/ansys/Documents/ansys_fluent_core_examples/* | |
| @python -m pytest --fluent-version=27.1 --solvermode $(PYTESTEXTRA) || python -m pytest --fluent-version=27.1 --solvermode $(PYTESTRERUN) | |
| unittest-all-27_1-no-codegen: |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| v271 = "27.1.0" | ||
| v261 = "26.1.0" |
There was a problem hiding this comment.
The v262 version entry was removed but v261 is still present. If v262 was intentionally removed, consider whether v261 and older versions should also be evaluated for removal to maintain consistency in supported versions. If v262 should still be supported, it should be kept alongside v271.
Context
Nightly dev test and force update image was updating 26. image.
Change Summary
Nightly dev test and force update image updates 271 Fluent image.