test: Standardize test skip reasons across test suite#4888
Open
mayankansys wants to merge 5 commits intomainfrom
Open
test: Standardize test skip reasons across test suite#4888mayankansys wants to merge 5 commits intomainfrom
mayankansys wants to merge 5 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes skip reason strings across the test suite by introducing canonical constants in conftest.py and replacing ad-hoc skip reasons with these shared literals.
Changes:
- Added three skip reason constants (
SKIP_UNKNOWN,SKIP_INVESTIGATING,SKIP_BLOCKED) intests/conftest.py - Updated all test files to import and use these constants instead of custom skip reason strings
- Categorized existing skipped tests according to the new standardized reasons
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/conftest.py | Defines three canonical skip reason constants |
| tests/test_tui_api.py | Replaces "Failing in github" with SKIP_UNKNOWN |
| tests/test_topy.py | Replaces "Unable to read generated python journal" with SKIP_BLOCKED |
| tests/test_settings_api.py | Replaces GitHub issue reference with SKIP_BLOCKED |
| tests/test_server_meshing_workflow.py | Replaces "Failing in Github randomly" with SKIP_UNKNOWN |
| tests/test_pre_post_session.py | Replaces "works fine locally but fails on CI" with SKIP_UNKNOWN |
| tests/test_new_meshing_workflow.py | Replaces GitHub issue and generic failure messages with SKIP_UNKNOWN |
| tests/test_meshing_workflow.py | Replaces "Wait for later implementation" with SKIP_INVESTIGATING |
| tests/test_mapped_api.py | Replaces "Currently only tested in backend" with SKIP_BLOCKED (20 occurrences) |
| tests/test_launcher_remote.py | Replaces GitHub issue reference with SKIP_UNKNOWN |
| tests/test_flobject.py | Replaces GitHub issue reference with SKIP_BLOCKED |
| tests/test_file_transfer_service.py | Replaces verbose skip reasons with SKIP_UNKNOWN and SKIP_BLOCKED |
| tests/test_field_data.py | Replaces GitHub issue reference with SKIP_BLOCKED |
| tests/test_datamodel_service.py | Replaces GitHub issue reference with SKIP_BLOCKED |
| tests/test_datamodel_api.py | Replaces GitHub issue reference with SKIP_BLOCKED (3 occurrences) |
| tests/test_aero_session.py | Replaces "Run this locally only" with SKIP_BLOCKED |
| tests/parametric/test_parametric_workflow.py | Replaces GitHub issue reference with SKIP_BLOCKED |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
prmukherj
reviewed
Feb 4, 2026
hpohekar
reviewed
Feb 4, 2026
seanpearsonuk
approved these changes
Feb 5, 2026
prmukherj
approved these changes
Feb 5, 2026
…m/ansys/pyfluent into fix/standardize-test-skip-reasons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Several tests were skipped using
@pytest.mark.skip, but the skip reasons were inconsistent and often unclear. Many reasons only described symptoms (for example, “works locally but fails on CI”) without stating whether the root cause was known, partially understood, or unknown. Similar situations were described using different wording across the test suite, making maintenance and investigation harder.Change Summary
conftest.py.Impact