Fix Windows CMake path handling. #1162
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CMake module path was not being handled correctly on Windows because backslashes were not escaped. This change explicitly replaces backslashes with forward slashes for the `CMAKE_MODULE_PATH` argument when building on Windows.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I found this CMake problem on Windows System independent of PR # 1161 after consulting Gemini of Android Studio. I suggest this PR over the one suggested in PR#1161 to distinguish the issue happened with Windows and no need to do unnecessary action if CMake running on different OS such as Linux/MAC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMake module path was not being handled correctly on Windows because backslashes were not escaped. This change explicitly replaces backslashes with forward slashes for the
CMAKE_MODULE_PATHargument when building on Windows.