Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

Conversation

@AnwarShahriar
Copy link

@AnwarShahriar AnwarShahriar commented Apr 10, 2018

@JoseAlcerreca I actually don't know how to approach this, I didn't contribute before so much. This fix the problem stated at issue #2 . Let me know if further modification needed. I think some refactoring could be done on ViewModels to move out the duplicate parts. Refactored a little bit as popularity decision logic based on like count is common on both ProfileObservableViewModel and ProfileObservableFieldsViewModel.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@AnwarShahriar
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@alinhayati
Copy link

Why isn't this issue merged to master then?

…profileobservalblefieldsviewmodel-state-fix

� Conflicts:
�	BasicSample/app/src/main/java/com/example/android/databinding/basicsample/data/ProfileObservableViewModel.kt
@AnwarShahriar
Copy link
Author

@diwakarsinghdiwakar this branch is updated and the conflicts are resolved. I believe this is now ready to be merged.

@codingjeremy codingjeremy changed the base branch from master to main September 29, 2020 19:04
@AnwarShahriar
Copy link
Author

@codingjeremy should we close it or there is still chances to get it merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants