Skip to content

Set content_disposition and content_type headers before serving a generated YAML file #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
charsbar wants to merge 2 commits into from
Closed

Set content_disposition and content_type headers before serving a generated YAML file #559

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bafae0
Set content_disposition and content_type headers before serving a gen…
charsbar May 3, 2025
af66c89
Remove unexpected characters from the action
charsbar May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/pause_2017/PAUSE/Web/Plugin/RenderYAML.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ sub register {
local $YAML::Syck::ImplicitUnicode = 1;
my $dump = YAML::Syck::Dump($data);
my $edump = Encode::encode_utf8($dump);
my $action = $c->req->param('ACTION') || 'pause';
$action =~ tr/a-z0-9_//cd;
$c->res->headers->content_disposition("attachment; filename=$action.yaml");
Copy link
Contributor

@Grinnz Grinnz May 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mojo won't allow to set newlines in the header value, but I'd still be careful about directly injecting a request parameter into a response header.

$c->res->headers->content_type('application/yaml');
$c->stash(format => "text");
$c->render(text => $edump);
return;
Expand Down