Theme data added#16
Open
aryamangodara wants to merge 3 commits intoanantcodes:masterfrom
aryamangodara:master
Open
Theme data added#16aryamangodara wants to merge 3 commits intoanantcodes:masterfrom aryamangodara:master
aryamangodara wants to merge 3 commits intoanantcodes:masterfrom
aryamangodara:master
Conversation
Author
|
@anantcodes can you please merge it |
Author
|
now this is ready to merge in the master @anantcodes |
Author
|
@anantcodes if not able to merge please mark it as hacktoberfest-accepted for my contribution 😊 |
Owner
|
Please squash the commits and send the PR again. |
Author
|
I dont know how to squash the commits , I will research and do it if I get time Although hactoberfest accepted but not merging will work for me |
Owner
|
Resolve the conflicts and squash the commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we can modify themes just from a single place ! (pink and amber are my favorites)
Added theme data in main.dart
also the best practices of imports are used
Also some other cosmetic changes here:-
Splash Screen:-
1. Only blank line is removed
Login:-
1. Login button is improved
2. Login button will take primary color by default
Home:-
1. Proper formatting by using commas
2. Changed HOME to Home for matching with other Navbar items