Open
Conversation
mahtaran
requested changes
Oct 24, 2023
Member
mahtaran
left a comment
mahtaran
left a comment
There was a problem hiding this comment.
Looking good overall, but have another look at the formatting, naming conventions, and code comments
Member
There was a problem hiding this comment.
Will need to be changed eventually when merging into Magus, but fine for now
Comment on lines
74
to
75
| LOGGER.info("HELLO FROM PRE INIT"); | ||
| LOGGER.info("DIRT BLOCK >> {}", Blocks.DIRT.getName()); |
Member
There was a problem hiding this comment.
Clean up leftover log statements
Comment on lines
79
to
115
| private void doClientStuff(final FMLClientSetupEvent event) { | ||
| // do something that can only be done on the client | ||
| //todo call this anytime the key mappings are updated | ||
| } | ||
|
|
||
| private void enqueueIMC(final InterModEnqueueEvent event) { | ||
| // some example code to dispatch IMC to another mod | ||
| InterModComms.sendTo("magus", "helloworld", () -> { | ||
| LOGGER.info("Hello world from the MDK"); | ||
| return "Hello world"; | ||
| }); | ||
| } | ||
|
|
||
| private void processIMC(final InterModProcessEvent event) { | ||
| // some example code to receive and process InterModComms from other mods | ||
| LOGGER.info("Got IMC {}", | ||
| event.getIMCStream().map(message -> message.messageSupplier().get()).collect(Collectors.toList()) | ||
| ); | ||
| } | ||
|
|
||
| // You can use SubscribeEvent and let the Event Bus discover methods to call | ||
| @SubscribeEvent | ||
| public void onServerStarting(FMLDedicatedServerSetupEvent event) { | ||
| // do something when the server starts | ||
| LOGGER.info("HELLO from server starting"); | ||
| } | ||
|
|
||
| // You can use EventBusSubscriber to automatically subscribe events on the contained class (this is subscribing to the MOD | ||
| // Event bus for receiving Registry Events) | ||
| // @Mod.EventBusSubscriber(bus = Mod.EventBusSubscriber.Bus.MOD) | ||
| // public static class RegistryEvents { | ||
| // @SubscribeEvent | ||
| // public static void onBlocksRegistry(final RegistryEvent.Register<Block> blockRegistryEvent) { | ||
| // // register a new block here | ||
| // LOGGER.info("HELLO from Register Block"); | ||
| // } | ||
| // } |
| * @param inputs Generic list of InputData to turn into InputPermutations. Good for containing inputs of multiple things | ||
| * that happen simultaneously. | ||
| */ | ||
| public record InputPermutation(List<InputData> inputs) implements InputData { |
| public static final Form STEP = new Form("step"); | ||
|
|
||
|
|
||
| //These two may not be necessary. |
Member
Author
There was a problem hiding this comment.
Kk, they're mainly for testing; I'm not sure we should even be registering input groups for forms right now, we may want to leave that up to each individual mod author.
Comment on lines
3
to
11
| /** | ||
| * Listeners store activators. Activators have a list of pre-requisites/events. | ||
| * Listeners search for those events and trigger all activators as needed. | ||
| * 1 listener per activator. | ||
| * Activators can have hard-coded pre-requisites or loaded ones from json files. | ||
| * Upon 'skill mode' being activated (whether through a toggle key or something else), all | ||
| * skill listeners are loaded. Listeners that are always active are the toggle listeners/initialise | ||
| * listeners. | ||
| **/ |
Member
Author
There was a problem hiding this comment.
Yeah that's a bit old....
|
|
||
| private int count; | ||
|
|
||
| public MultiModifierData() { |
Member
There was a problem hiding this comment.
Be sure to document that the default is 1
Member
Author
There was a problem hiding this comment.
Ya, I'll get Aidan to help with his part of this
src/main/java/com/amuzil/omegasource/magus/skill/util/traits/skilltraits/XPTrait.java
Outdated
Show resolved
Hide resolved
aidan99davis
force-pushed
the
FD/activatorSetup
branch
from
5ea7ad4 to
b8a7337
Compare
Also ensured no mutability issues for a hashmap would arise
…into FD/activatorSetup
…into FD/activatorSetup
builds, but setupListener() not fully implemented
now all InputModules are inserting into static formsTree field
fixed InputConverter.buildPathFrom()
OnPlayerLeaveWorld() method not working for client side
…into FD/activatorSetup
…into FD/activatorSetup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desc:
Primary focus on the Form implementations, rather than the input modules (blame Aidan for those).
Focuses on issue #2 . Does not close it, as there are issues to be solved and design ideas that need to be addressed- see my TODO and other relevant comments within the commit.
Impact:
This PR will add basic Form implementation to the API, as well as generic InputData support for chaining together any conceivable sequence of inputs from any compatible source. It does not include a thorough InputModule, but again, @aidan99davis for that.