Skip to content

Conversation

@davramov
Copy link
Contributor

@davramov davramov commented May 7, 2025

Upgrade Prefect 2.19.5 -> 2.20.17

Upgrade Prefect 2.19.5 -> 2.20.17
@davramov
Copy link
Contributor Author

davramov commented May 7, 2025

The build test failed, looks like griffe needs to be upgraded as well:

ERROR: Cannot install -r requirements.txt (line 10) and griffe==0.47 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested griffe==0.47
    prefect 2.20.17 depends on griffe<2.0.0 and >=0.49.0

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip to attempt to solve the dependency conflict

@davramov
Copy link
Contributor Author

davramov commented May 7, 2025

_____________ ERROR collecting orchestration/_tests/test_scicat.py _____________
orchestration/_tests/test_scicat.py:10: in <module>
    from orchestration.flows.scicat.ingest import ingest_dataset_task
orchestration/flows/scicat/ingest.py:11: in <module>
    @flow(name="scicat_dataset_ingest")
/opt/hostedtoolcache/Python/3.11.12/x64/lib/python3.11/site-packages/prefect/flows.py:1563: in flow
    Flow(
/opt/hostedtoolcache/Python/3.11.12/x64/lib/python3.11/site-packages/prefect/context.py:188: in __register_init__
    original_init(__self__, *args, **kwargs)
/opt/hostedtoolcache/Python/3.11.12/x64/lib/python3.11/site-packages/prefect/flows.py:347: in __init__
    self.parameters = parameter_schema(self.fn)
/opt/hostedtoolcache/Python/3.11.12/x64/lib/python3.11/site-packages/prefect/utilities/callables.py:3[25](https://github.com/als-computing/splash_flows_globus/actions/runs/14893363224/job/41830596235?pr=80#step:6:26): in parameter_schema
    return generate_parameter_schema(signature, docstrings)
/opt/hostedtoolcache/Python/3.11.12/x64/lib/python3.11/site-packages/prefect/utilities/callables.py:408: in generate_parameter_schema
    schema = create_schema("Parameters", model_cfg=ModelConfig, **model_fields)
/opt/hostedtoolcache/Python/3.11.12/x64/lib/python3.11/site-packages/prefect/_internal/pydantic/v2_schema.py:132: in create_v2_schema
    model = create_model(
/opt/hostedtoolcache/Python/3.11.12/x64/lib/python3.11/site-packages/pydantic/main.py:1761: in create_model
    return meta(
/opt/hostedtoolcache/Python/3.11.12/x64/lib/python3.11/site-packages/pydantic/_internal/_model_construction.py:110: in __new__
    config_wrapper = ConfigWrapper.for_model(bases, namespace, kwargs)
/opt/hostedtoolcache/Python/3.11.12/x64/lib/python3.11/site-packages/pydantic/_internal/_config.py:138: in for_model
    config_new.update(config_from_namespace)
E   TypeError: 'type' object is not iterable

This seems related to the tests failing after rebasing this other PR: #62

What worked was some combination of:

  • upgrading Python to 3.12.5
  • upgrading numpy>=1.26.4
  • pinning pydantic==2.11

I'll test to see if these adjustments work here.

….17-python3.11, matching the prefect_server. Also upgrading numpy>=1.26.4 and pinning pydantic==2.11 to hopefully avoid build errors during pytest (still cannot reproduce locally)
@davramov davramov requested a review from dylanmcreynolds May 8, 2025 18:43
@dylanmcreynolds dylanmcreynolds merged commit 8974868 into als-computing:main May 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants