Optimize the test_ip function in the request_tester.lua file#161
Open
houjq3 wants to merge 1 commit intoalexazhou:masterfrom
Open
Optimize the test_ip function in the request_tester.lua file#161houjq3 wants to merge 1 commit intoalexazhou:masterfrom
houjq3 wants to merge 1 commit intoalexazhou:masterfrom
Conversation
Owner
|
I'am very thank you for your work, but i can't merage this pull request currently. This commit can handle some condition but may cause risk some times. Like user can modify there header to bypass filter. I think i need to add some config , let user can choose if they would like to use ip address in the header. After that i would like to merage the PR |
|
This code is best to customize. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.