[DNM] 🧪 Instrument C-extensions to collect coverage #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
|
I expect a far from 100% coverage because of CPython API calls error checking. |
webknjaz
force-pushed
the
maintenance/c-coverage-infra
branch
5 times, most recently
from
5ea38c2 to
453481f
Compare
| log.info('Copying tracing data into the build directory') | ||
| tracing_data_file_in_tmp_dir = self._ext_tracing_file_for(ext) | ||
| tracing_data_in_package_dir = self._ext_tracing_data_dir_map[ext.name] | ||
| tracing_data_file_in_package_dir = tracing_data_in_package_dir / tracing_data_file_in_tmp_dir |
Check notice
Code scanning / CodeQL
Unused local variable Note
CodSpeed Performance ReportMerging #1228 will improve performances by 12.2%Comparing Summary
Benchmarks breakdown
|
This was referenced Jul 2, 2025
webknjaz
force-pushed
the
maintenance/c-coverage-infra
branch
from
0bc563e to
8bea87b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This patch sets up the infrastructure for collecting and reporting coverage for C-extensions. It includes updates to packaging, test runner and CI/CD.
Warning
THE PATCH IS INCOMPLETE. THIS IS @webknjaz's PLAYGROUND FOR NOW. DO NOT MERGE!
I've been able to generate coverage reports locally, with a series of manual commands. They still need to be integrated and cleaned up to fit well together.
Are there changes in behavior for the user?
This is a contributor-facing change, allowing them to expose gaps in coverage of C-extensions.
Related issue number
N/A
Checklist