Skip to content

chore(deps): update dependency sphinx to v9 #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency sphinx to v9 #368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ dev = [
"pytest-xdist[psutil]>=3.8.0,<4",
"ruff>=0.14.8,<1",
"scalene>=1.5.55,<2",
"sphinx>=8.2.3,<9",
"sphinx>=9.1,<10",
Copy link

@sentry sentry bot Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The update to sphinx>=9.1 is incompatible with the project's declared Python support for version 3.11 in pyproject.toml, which will cause installation failures.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The project's pyproject.toml is being updated to require sphinx>=9.1,<10. However, the official Sphinx 9.1.0 release dropped support for Python 3.11 and requires Python 3.12 or newer. The project's configuration still declares support for Python 3.11 via requires-python = ">=3.11, <3.15". This incompatibility will cause a hard dependency resolution failure for any user attempting to install this package on a Python 3.11 environment, preventing installation entirely.

💡 Suggested Fix

To resolve the incompatibility, either update the requires-python declaration in pyproject.toml to ">=3.12, <3.15" to reflect the new minimum version, or revert the Sphinx dependency update to a version that still supports Python 3.11, such as sphinx<9.1.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: pyproject.toml#L192

Potential issue: The project's `pyproject.toml` is being updated to require
`sphinx>=9.1,<10`. However, the official Sphinx 9.1.0 release dropped support for Python
3.11 and requires Python 3.12 or newer. The project's configuration still declares
support for Python 3.11 via `requires-python = ">=3.11, <3.15"`. This incompatibility
will cause a hard dependency resolution failure for any user attempting to install this
package on a Python 3.11 environment, preventing installation entirely.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8077303

"sphinx-autobuild>=2025.8.25,<2026",
"sphinx-click>=6.2.0,<7",
"sphinx-copybutton>=0.5.2,<1",
Expand Down
Loading