fix(x-aep-resource): fix patterns regex#46
Merged
toumorokoshi merged 2 commits intoaep-dev:mainfrom Nov 11, 2025
Merged
Conversation
Member
Author
|
converting to draft because I think all of these regex requires a bit of an overhaul. |
toumorokoshi
force-pushed
the
yft/fix-patterns-regex
branch
2 times, most recently
from
ec7fbb5 to
e3e4135
Compare
The patterns regex vas previously incorrect (not allowing for underscore ids).
toumorokoshi
force-pushed
the
yft/fix-patterns-regex
branch
from
e3e4135 to
9ce9eae
Compare
rambleraptor
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patterns regex vas previously incorrect (not allowing for underscore ids).
A few other patterns did not match correctly, so resolved those as well.
Added a script to validate that the regex matches the examples to help serve as an additional verification.