Add aep.api.resource annotation for resource definitions#44
Merged
toumorokoshi merged 7 commits intomainfrom Nov 9, 2025
Merged
Add aep.api.resource annotation for resource definitions#44toumorokoshi merged 7 commits intomainfrom
toumorokoshi merged 7 commits intomainfrom
Conversation
Co-authored-by: toumorokoshi <391240+toumorokoshi@users.noreply.github.com>
Co-authored-by: toumorokoshi <391240+toumorokoshi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add aep.api.resource annotation for resources
Add aep.api.resource annotation for resource definitions
Nov 9, 2025
toumorokoshi
requested changes
Nov 9, 2025
Member
toumorokoshi
left a comment
There was a problem hiding this comment.
thanks! please see comments, getting close.
toumorokoshi
reviewed
Nov 9, 2025
Co-authored-by: toumorokoshi <391240+toumorokoshi@users.noreply.github.com>
Co-authored-by: toumorokoshi <391240+toumorokoshi@users.noreply.github.com>
toumorokoshi
reviewed
Nov 9, 2025
toumorokoshi
reviewed
Nov 9, 2025
Co-authored-by: toumorokoshi <391240+toumorokoshi@users.noreply.github.com>
Member
|
@rambleraptor I think we have one more proto annotation we need add for ourselves 😅 . Can you take a look? |
rambleraptor
approved these changes
Nov 9, 2025
Member
rambleraptor
left a comment
There was a problem hiding this comment.
Looks great to me. We'll need to make the corresponding linter changes as well
Member
agreed! Is something you can take on @rambleraptor ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
aep.api.resourceproto annotation similar togoogle.api.resource, enabling resource metadata definition with AEP-specific extensions.Changes
proto/aep-api/aep/api/resource.protoResourceDescriptormessage with fields:type,pattern(repeated),singular,plural,parent(repeated)google.protobuf.MessageOptions(ID: 1266)parentfield allows specifying multiple parent resource types in singular form_idsuffix convention (e.g.,{project_id},{topic_id})Usage
Subset of google.api.resource fields chosen per issue requirements. Extension ID 1266 from registered aep.dev range (1264-1274).
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.