Skip to content

Conversation

@sandeep-paliwal
Copy link
Contributor

Fixed all test failures. There are one set of tests still failing for credential related tests because of following issue . Once the issue is fixed remaining tests should run fine.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Manual e2e run

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3eb9382) to head (42c5664).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #91   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          533       543   +10     
  Branches        15        15           
=========================================
+ Hits           533       543   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@shazron shazron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that issue you mentioned might be related to this? adobe/aio-cli-lib-console#85

…to create credential.

As as workaround calling the API directly using axios.
… dependent tests as there is problem with jest and API call ends up getting timedout.
@sandeep-paliwal sandeep-paliwal merged commit 937ee2f into master Jan 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants