This repository was archived by the owner on Mar 30, 2022. It is now read-only.
Fix 4.1 adapter under Rubinius#351
Open
chewi wants to merge 1 commit intoactiverecord-hackery:masterfrom
Open
Conversation
Calling return inside a block under Rubinius results in a LocalJumpError, at least with version 2.3.0. This is probably a Rubinius bug but it is easy enough to work around it here.
Contributor
|
@bigxiang FWIW, I'm not a fan of merging these kinds of alternative-Ruby fixes if they're for a bug in the interpreter. The change here (calling |
Author
|
each + break might have been slightly less confusing than find + break but each returns the array rather than nil when it reaches the end. |
Author
|
I've reported the issue to Rubinius at rubinius/rubinius#1312. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling return inside a block under Rubinius results in aLocalJumpError, at least with version 2.3.0. This is probably a Rubinius bug but it is easy enough to work around it here.
I am making the assumption that
accept!will never return nil. Is that reasonable?Unfortunately one other spec still fails but I don't think it's Squeel's fault. It's something to do with preloading HABTM associations, possibly caused by the Rubinius implementation of flat_map.