Fix wildcard escaping for SQLite and other databases#1660
Open
heyjosephme wants to merge 1 commit intoactiverecord-hackery:mainfrom
Open
Fix wildcard escaping for SQLite and other databases#1660heyjosephme wants to merge 1 commit intoactiverecord-hackery:mainfrom
heyjosephme wants to merge 1 commit intoactiverecord-hackery:mainfrom
Conversation
Previously, escape_wildcards only escaped special characters (%, _, \) for MySQL and PostgreSQL, leaving SQLite and other databases vulnerable to unintended wildcard matches in LIKE queries. This commit replaces the database-specific escaping logic with Rails' sanitize_sql_like method, which works consistently across all database adapters. Changes: - Replaced database-specific regex with sanitize_sql_like - Updated test expectations for SQLite to match correctly escaped output - Simplified code from 13 lines to 1 line Fixes activerecord-hackery#1581
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1581
Problem
SQLite and non-MySQL/PostgreSQL databases weren't escaping SQL wildcards (%, _, ) in LIKE queries, causing unintended matches.
Solution
Replace database-specific escaping with Rails'
sanitize_sql_likemethod which works for all databases.Changes
escape_wildcardsmethod inlib/ransack/constants.rbspec/ransack/predicate_spec.rbTesting
This is my first contribution to Ransack. Looking forward to feedback!