This repository was archived by the owner on Dec 8, 2025. It is now read-only.
Hashing of sg, sh, g_n and g_h not necessary#8
Open
jhasse wants to merge 1 commit intoZerocoin:devfrom
Open
Conversation
Member
|
This looks about right. We have a paper deadline on the 5th so until then I don't want to mess with it, least it turn out it was something critical. Thanks |
Contributor
Author
|
Any news about the paper? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure, but isn't the hashing of sg, sh, g_h and g_h redundant since they are also part of *params?
I've also added const to some values in the proof (makes it a little bit clearer IMHO).
I also noticed that
isn't needed and it's possible to directly return with the result.