Skip to content

Test that Filters.notRetired() does not filter non-retired entries #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emlun merged 2 commits into from
Feb 10, 2026
Merged

Test that Filters.notRetired() does not filter non-retired entries #457

emlun merged 2 commits into from
Feb 10, 2026

Conversation

@emlun
Copy link
Member

@emlun emlun commented Feb 10, 2026

For example, the test now detects if the filter implementation is changed to (entry) -> false which was not detected before.

emlun added 2 commits February 9, 2026 16:00
@emlun
Delete unnecessary attributes from notRetired filter test
c186ad8
@emlun
Test that Filters.notRetired() does not filter non-retired entries
157d79a 
For example, the test now detects if the filter implementation is changed to
`(entry) -> false` which was not detected before.
@emlun emlun requested a review from fdennis February 10, 2026 09:59
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

Test Results

2 308 tests  ±0   2 300 ✅ ±0   1m 7s ⏱️ +5s
   46 suites ±0       8 💤 ±0 
   46 files   ±0       0 ❌ ±0 

Results for commit 157d79a. ± Comparison against base commit 3825292.

@emlun emlun merged commit 157d79a into mds-3.1.1-retired Feb 10, 2026
20 checks passed
@emlun emlun deleted the mds-3.1.1-retired-test branch February 10, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fdennis fdennis fdennis approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emlun @fdennis