Merged
Conversation
Collaborator
|
Thanks for the submission. Actually, the change will be: xoops_setcookie('xo_upgrade_lang', $upgrade_language, 0, '', '');but I didn't commit it yet. I'll approve yours right now, and then update it with the rest of the stuff that I'm working on. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a type error in the upgrade process by correcting the xoops_setcookie function call to use proper type-safe parameters. The xoops_setcookie function signature was modernized with strict type hints, requiring the $expire parameter to be an int rather than null.
Changes:
- Updated the
xoops_setcookiecall in the upgrade language determination logic to pass0instead ofnullfor the expire parameter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.