bugfix: queue: uint64 is never less than 0#201
Open
detailyang wants to merge 1 commit intoWorkiva:masterfrom
Open
bugfix: queue: uint64 is never less than 0#201detailyang wants to merge 1 commit intoWorkiva:masterfrom
detailyang wants to merge 1 commit intoWorkiva:masterfrom
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Author
|
It looks like some tests broken, because the diff is actually below 0 |
Collaborator
ryanjackson-wf
left a comment
There was a problem hiding this comment.
Thank you for pointing out this bug. I might be inclined to do the math by hand as it were with the raw unsigned numbers (in perhaps a helper method) to ensure that those int64 conversions don't bite us for very large values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diff should be int64 else it never less than 0