Skip to content

Fixed sanitize_term_field missing default value#8670

Closed
dilipbheda wants to merge 2 commits intoWordPress:trunkfrom
dilipbheda:ticket/63257
Closed

Fixed sanitize_term_field missing default value#8670
dilipbheda wants to merge 2 commits intoWordPress:trunkfrom
dilipbheda:ticket/63257

Conversation

@dilipbheda
Copy link

@github-actions
Copy link

github-actions bot commented Apr 9, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props dilipbheda, wildworks, sirlouen, rollybueno, mindctrl.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Apr 9, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@rollybueno
Copy link
Member

Looks good to me 👍

Copy link
Member

@SirLouen SirLouen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, but technically correct.

@mindctrl
Copy link

mindctrl commented Nov 3, 2025

@dilipbheda could you bring your PR up to date with the trunk branch? This will ensure the patch applies cleanly and will also run the test suite again (which failed for some reason, but the logs are no longer available to understand why).

@t-hamano
Copy link
Contributor

t-hamano commented Nov 7, 2025

could you bring your PR up to date with the trunk branch?

I handled it.

@mindctrl
Copy link

mindctrl commented Nov 7, 2025

Given your question on the Trac ticket, I think we should punt this one and leave room for discussion and discovery.

@t-hamano
Copy link
Contributor

Setting a default value may cause backward compatibility issues. It's probably sufficient to simply update the DocBlock. See #10918

@t-hamano t-hamano closed this Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants