get_block_wrapper_attributes(): Preserve zero value#10921
get_block_wrapper_attributes(): Preserve zero value#10921t-hamano wants to merge 5 commits intoWordPress:trunkfrom
Conversation
Co-authored-by: Weston Ruter <westonruter@gmail.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| if ( ! empty( $new_attributes ) ) { | ||
| foreach ( $new_attributes as $attribute_name => $attribute_value ) { | ||
| if ( empty( $output[ $attribute_name ] ) ) { | ||
| if ( ! array_key_exists( $attribute_name, $output ) || '' === (string) $output[ $attribute_name ] ) { |
There was a problem hiding this comment.
What if $output[ $attribute_name ] is a non-string, like true?
There was a problem hiding this comment.
Wouldn't that result in " $attribute_value" being erroneously appended onto it?
2 participants
Note
This PR is the same as #10663. I submitted this new PR because I accidentally closed #10663 and it can no longer be reopened.
Trac ticket: https://core.trac.wordpress.org/ticket/64452
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.