Rewrite VRM Component in TypeScript #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
DavidPeicho
reviewed
Feb 20, 2025
vrm.ts
Outdated
| const {root, extensions} = this.engine.scene.instantiate(prefab); | ||
| root!.children.forEach((child) => (child.parent = this.object)); | ||
| this._initializeVrm(prefab.extensions, extensions?.idMapping!); | ||
| root!.destroy(); |
Collaborator
There was a problem hiding this comment.
To avoid making too much changes in a row, this is fine to keep. However, I am pretty confident with the new system we can actually circumvent this in a nicer way.
We could use the gltf.extensions to do the changes directly on the prefab itself, since the original mapping works on that. Then instantiate the prefab in onActivate, and delete the objects in onDeactivate
Signed-off-by: Squareys <squareys@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also enables sourcemaps for better stack traces.