Add a helper method for infallible API endpoints #6432
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of RPC endpoints have turned out to be infallible, which means that they do not return an error under normal circumstances. Any error is the result of either an unexpected server error or a bug in the client code that makes the call thus all instances where such a request fails it should fail hard and loud.
This PR introduces a new alert dialog that is raised whenever such an unexpected error case is hit. This is strictly meant to be a fall-back case and should not be relied on as an expected behavior.
Example of the code before and after:
WCF/ts/WoltLabSuite/Core/Api/ModerationQueues/CloseReport.ts
Lines 14 to 26 in 3245fcd
After the PR:
WCF/ts/WoltLabSuite/Core/Api/ModerationQueues/CloseReport.ts
Lines 14 to 22 in dccb595