gamepad: fix ABI break in wpe_gamepad_client_interface #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In WebPlatformForEmbedded#134, the analog_button_changed field was added to wpe_gamepad_client_interface, but it missed removing one of trailing reserved fields, so the struct size grew and broke upstream WPE build in developer mode: ``` GamepadLibWPE.cpp:62:5: error: missing field '_wpe_reserved3' initializer [-Werror,-Wmissing-field-initializers] ```
aperezdc
approved these changes
Feb 6, 2025
Contributor
|
I had commented about the need to do this in #133 (comment) but the PR that ultimately landed was #134 which didn't take into account my comment. Good catch @cadubentzen, thanks for the fix! |
Contributor
|
Backported into the 1.16 branch as commit 0b7baf9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #134, the
analog_button_changed fieldwas added towpe_gamepad_client_interface, but it missed removing one of trailing reserved fields, so the struct size grew and broke upstream WPE build in developer mode: