Skip to content

Conversation

@emutavchi
Copy link
Collaborator

This is a potential fix for the issue #1592

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical bug in the DFG JIT compiler for 32-bit architectures (JSVALUE32_64) that caused crashes during tail call optimization. The issue occurred when the code incorrectly decided to skip the FPR (floating-point register) loading path if either the payload GPR or tag GPR was available individually, when both registers are actually required for a complete JSValue in the 32-bit representation.

  • Fixed the logic to only skip FPR path when both tag and payload GPRs are available, not just one
  • Refactored the availability check into a lambda function for code clarity

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants