-
Notifications
You must be signed in to change notification settings - Fork 0
Initial Docusaurus setup for GH-Pages #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@edoyango, when you are able, could you please check this PR, I'm just folding in some Markdown documentation onto main so I can deploy on GitHub Pages, cheers 😄 |
edoyango
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I've added a handful of comments but they're all suggestions, with the exception of mentioning over-fitting - that's actually quite important. Some other general suggestions:
- Add a link to your docs in the readme (I guess you were going to do this after the site is actually deployed)
- in training-output.md, I suggest that you include links to more in-depth guides of how to interpret the output, just so you don't have to write it yourself. e.g. https://neptune.ai/blog/f1-score-accuracy-roc-auc-pr-auc or https://docs.ultralytics.com/guides/yolo-performance-metrics/
- I can see that you've added some images of denoise workflows, but it could be good to show off some of your metrics that are included in your publication (maybe you planned on doing this after publishing).
Co-authored-by: Edward Yang <94523015+edoyango@users.noreply.github.com>
… into gh-pages pulling upstream commits
|
@edoyango awesome thanks, having implemented all suggestions, will need one more review before I can merge to main |
edoyango
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Copied across docusaurus documentation project from personal git repo for deployment on PartiNet github pages