-
Notifications
You must be signed in to change notification settings - Fork 14
Add Runge Kutta 3 Time Integration #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ayers (soft landing)
…_material_interface
Member
Member
Author
… in 3D. Added VoidEtching python example. Removed redundant prepareLS(); call in computeRates during advection. Updated RK3 substepping.
Member
Author
|
There are several things that need to be adapted to have the RK3 time integration scheme work with ViennaPS. This is still work in progress and it should not be merged with master at this stage, otherwise ViennaPS workflows will be broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


This pull request introduces a 3rd-order Runge-Kutta (RK3) time integration scheme for advection, offering higher-order temporal accuracy compared to the existing Forward Euler method. This also meant a slight refactoring of the Advect class. Added lsAdvectForwardEuler.hpp and lsAdvectRungeKutta3.hpp.
Modified Advect to take the adaptiveTimeStepSubdivisions parameter instead of adaptiveTimeStepThreshold. This way, user can choose how many steps should be taken per CFL during thin layer etching.
Added Python example for Epitaxy.
Added several advection tests: