Remove to_f in criteria chain#196
Open
ayemos wants to merge 1 commit intoVeraticus:masterfrom
ayemos:remove_to_f_in_criteria_chain
Open
Remove to_f in criteria chain#196ayemos wants to merge 1 commit intoVeraticus:masterfrom ayemos:remove_to_f_in_criteria_chain
ayemos wants to merge 1 commit intoVeraticus:masterfrom
ayemos:remove_to_f_in_criteria_chain
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the AWS-SDK document, in api version 2012-08-10, range key can be either a type of String, Integer or Binary when it comes with comparison conditions. (e.g. gt, lt, gte, ...)
I guess it's user's responsibility to make range keys match with schema definition and should omit this conversion so that we can make use of comparison conditions not only with Integer but also String and/or other data types.
Please review it. 🙇