Added ability to use a custom field name for optimistic locking#187
Open
sumocoder wants to merge 1 commit intoVeraticus:masterfrom
Open
Added ability to use a custom field name for optimistic locking#187sumocoder wants to merge 1 commit intoVeraticus:masterfrom
sumocoder wants to merge 1 commit intoVeraticus:masterfrom
Conversation
Collaborator
|
Hello, Thank you for this improvement! Would you mind making the interface conform to ActiveRecord's API (http://api.rubyonrails.org/classes/ActiveRecord/Locking/Optimistic.html)? I'd like Dynamoid to conform to ActiveRecord as much as reasonably possible. |
Author
|
Okay thanks! I'll make the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the option to define a custom field name for optimistic locking.
optimistic_lock_field :some_custom_fieldYou can still use the old way
field lock_versionIf both lock_version and a custom lock field is set, It will make use of the custom lock field