Skip to content

Conversation

@davidsteiner
Copy link
Member

No description provided.

@davidsteiner davidsteiner linked an issue Jan 19, 2026 that may be closed by this pull request
@davidsteiner davidsteiner force-pushed the 264-replace-unwraps-with-error-propagation-in-session-code branch from 1908146 to 0a6ad71 Compare January 19, 2026 15:10
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 85.65815% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.83%. Comparing base (a6f7560) to head (467cadf).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/hotfix/src/session.rs 84.98% 56 Missing ⚠️
crates/hotfix/src/initiator.rs 82.14% 15 Missing ⚠️
crates/hotfix-dictionary/src/quickfix.rs 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   87.16%   88.83%   +1.67%     
==========================================
  Files          84       84              
  Lines        7557     7948     +391     
==========================================
+ Hits         6587     7061     +474     
+ Misses        970      887      -83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@davidsteiner davidsteiner force-pushed the 264-replace-unwraps-with-error-propagation-in-session-code branch 2 times, most recently from 7cf4c00 to 7055e28 Compare January 19, 2026 20:19
@davidsteiner davidsteiner force-pushed the 264-replace-unwraps-with-error-propagation-in-session-code branch from 7055e28 to ca35e19 Compare January 19, 2026 20:29
@davidsteiner davidsteiner force-pushed the 264-replace-unwraps-with-error-propagation-in-session-code branch from 69f8ea7 to 09709ab Compare January 19, 2026 20:57
@davidsteiner davidsteiner force-pushed the 264-replace-unwraps-with-error-propagation-in-session-code branch from 09709ab to 467cadf Compare January 19, 2026 21:08
@davidsteiner davidsteiner merged commit cf0db91 into main Jan 20, 2026
4 checks passed
@davidsteiner davidsteiner deleted the 264-replace-unwraps-with-error-propagation-in-session-code branch January 20, 2026 13:45
This was referenced Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace unwraps with error propagation in session code

3 participants